Merged
Conversation
Contributor
|
Very nice job, thank you for your contribution. will review it tomorrow |
klesh
approved these changes
Jun 2, 2022
Contributor
klesh
left a comment
klesh
left a comment
There was a problem hiding this comment.
This is a great implementation, very professional! I like it very much.
Sorry for reviewing it so later, I would like it to be merged ASAP.
If @matrixji could find time to make some minor improvements, or we could merge it today, and improve them later
Member
Author
|
Comments fixed and rebased from upstream. |
issue: apache#1991 Signed-off-by: Ji Bin <matrixji@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #1991
Signed-off-by: Ji Bin matrixji@live.com
label(bug, feature etc.)Summary
Does this close any open issues?
Partly #1991
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.