add migration for directrun; update feishu model#2030
Merged
klesh merged 4 commits intoapache:mainfrom Jun 6, 2022
Merged
Conversation
likyh
force-pushed
the
issues/2029
branch
5 times, most recently
from
6cfd53f to
9ae8bdc
Compare
klesh
approved these changes
Jun 6, 2022
plugins/helper/batch_save.go
Outdated
| } | ||
|
|
||
| func hasPrimaryKey(ifv reflect.Type) bool { | ||
| func hasPrimaryKey(ifv reflect.Type, needRecursion bool) bool { |
Contributor
There was a problem hiding this comment.
when do we need this flag? I think it should be always recursive except when primaryKey is found inside gorm tag?
warren830
pushed a commit
to merico-ai/lake
that referenced
this pull request
Jun 6, 2022
* add migration for directrun; update feishu model * fix: fix primary read bug when time is primary key * open needRecursion * delete needRecursion Co-authored-by: linyh <yanghui@meri.co>
warren830
pushed a commit
to merico-ai/lake
that referenced
this pull request
Jun 8, 2022
* add migration for directrun; update feishu model * fix: fix primary read bug when time is primary key * open needRecursion * delete needRecursion Co-authored-by: linyh <yanghui@meri.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy migrate from
services/init.gotodirectrun.gofor migration in cli;delete
idin feishu model and add new primaryKeySummary 2
I want to keep this PR small, but I got a error when fix feishu model because of time cannot use as primary key.
So Fix it in commit 2.
StartTime is a struct so
isPrimaryKeynot run and StartTime cannot detect as primary key.I fix it like this: check isPrimaryKey before check struct; add need_recursion to avoid unuseful recursion
Does this close any open issues?
close #2029
close #2014
close #2031
Key Points