fix: jira connections api should not depend on encKey#2034
Merged
warren830 merged 1 commit intoapache:mainfrom May 30, 2022
Merged
fix: jira connections api should not depend on encKey#2034warren830 merged 1 commit intoapache:mainfrom
warren830 merged 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2032 by the following approach:
for Jira connections endpoint, when
.envgot deleted and decryption failed, no more 400 bad requests, but with emptybasic auth, so developer/user can still list out all Jira connections, and update theirbasic authwhich will then be encrypted with the newly generated key.Does this close any open issues?
Fixes #2032