Skip to content

fix(gitlab): fix issue assignee id type#2086

Merged
warren830 merged 1 commit intoapache:mainfrom
merico-ai:fix-gitlab-assignee-id
Jun 6, 2022
Merged

fix(gitlab): fix issue assignee id type#2086
warren830 merged 1 commit intoapache:mainfrom
merico-ai:fix-gitlab-assignee-id

Conversation

@warren830
Copy link
Copy Markdown
Contributor

@warren830 warren830 commented Jun 6, 2022

Summary

change issue assignee id's data type to int in order to keep the same as other user ids in gitlab
Besides, will not convert gitlab issue assignee id to domain layer, as gitlab user does not have an id property

Does this close any open issues?

closes #2085

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@warren830 warren830 force-pushed the fix-gitlab-assignee-id branch from 9445700 to 5209259 Compare June 6, 2022 04:24
Copy link
Copy Markdown
Contributor

@mindlesscloud mindlesscloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warren830 warren830 merged commit 0a69bd7 into apache:main Jun 6, 2022
@warren830 warren830 deleted the fix-gitlab-assignee-id branch June 6, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gitlab extractApiIssues failed.

2 participants