Merged
Conversation
warren830
changed the title
warren830
force-pushed
the
ref-gitlab-conn-id-mr-commit
branch
6 times, most recently
from
669901e to
e521772
Compare
mappjzc
approved these changes
Jun 20, 2022
mappjzc
approved these changes
Jun 20, 2022
likyh
reviewed
Jun 20, 2022
| } | ||
|
|
||
| // Prepare _tool_gitlab_pull_requests for mr_commit convertor test | ||
| err := dataflowTester.Db.Migrator().DropTable("_raw_gitlab_api_merge_requests") |
Contributor
There was a problem hiding this comment.
it's not necessary. Because ImportCsvIntoRawTable dropped.
| @@ -1,64 +1 @@ | |||
| sha,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark,additions,deletions,dev_eq,message,author_name,author_email,authored_date,author_id,committer_name,committer_email,committed_date,committer_id | |||
| 03b566ec2af3106808f385dacdbd3edf54f4c2c4,"{""ConnectionId"":1,""ProjectId"":20171709}",_raw_gitlab_api_commit,3,,7,1,0,"update README.md | |||
Contributor
There was a problem hiding this comment.
Is empty csv right? There are some commits in _tool_gitlab_commits.csv
warren830
force-pushed
the
ref-gitlab-conn-id-mr-commit
branch
2 times, most recently
from
f7e9f5b to
7ef2616
Compare
likyh
approved these changes
Jun 20, 2022
abeizn
force-pushed
the
ref-gitlab-conn-id-mr-commit
branch
from
7ef2616 to
e038b20
Compare
abeizn
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add conn id and e2e to mr commits
delete conn id for commit test
Does this close any open issues?
Please mention the issues here.
Screenshots
### Other Information Any other information that is important to this PR.