Skip to content

fix config-ui: cleanup usage of image assets and icons | v0.11.0#2345

Merged
mindlesscloud merged 5 commits intoapache:release-v0.11-hotfixfrom
e2corporation:jc-2320-config-ui-image-cleanup
Jun 27, 2022
Merged

fix config-ui: cleanup usage of image assets and icons | v0.11.0#2345
mindlesscloud merged 5 commits intoapache:release-v0.11-hotfixfrom
e2corporation:jc-2320-config-ui-image-cleanup

Conversation

@e2corporation
Copy link
Contributor

@e2corporation e2corporation commented Jun 24, 2022

Config-UI / Images & Icons Cleanup

This PR updates images and icon usage on Config-UI to resolve conflicts with licensing requirements. These changes will also need to be cherry-picked to main branch after merge.

  • Remove unused PNG/SVG Image assets
  • Remove Headline Icons
  • Replace main Provider Brand Logos (provided by Product & Design Team)
  • Use generic icon for ae, dbt, gitextractor and refdiff plugins
  • Cleanup Imports

Image / Icon Context

Developer notes on remaining assets in config-ui/images:


./images/:
cron-help.png // Help context for cron (Created by me, licensed for devlake?)
feishu.png // Feishu's Brand Logo
help.svg // Help Icon Exported from Blueprint JS Icons (Apache 2.0 licensed)
logo.svg // Merico Logo Asset (licensed for devlake?)
slack-mark-monochrome-black.svg // Slack Brand Logomark
slack-rgb.svg // Slack Brand Logo

./images/help:
github-help.png // Github Help Context  (Created by me, licensed for devlake?, obsolete after v11)
gitlab-help.png // Gitlab Help Context (Created by me, licensed for devlake?, obsolete after v11)
jira-help.png  // JIRA Help Context (Created by me, licensed for devlake?, obsolete after v11)

./images/integrations:
github.svg // GitHub Brand Logo
gitlab.svg // GitLab Brand Logo
jenkins.svg // Jenkins Brand Logo
jira.svg // JIRA Brand Logo

Additional Images Outside of Config-UI

⚠️ BE and/or Product Team needs to evaluate these images for any licensing issues. @klesh @Startrekzky @hezyin

grafana/img/jira.png
grafana/img/delivery_cost.png
grafana/img/delivery_value.png
grafana/img/delivery_capability.png
grafana/img/gitlab.png
grafana/img/customer.png
grafana/img/practice_cross_domain.png
grafana/img/practice_process_delivery_velocity.png
grafana/img/trend.png
grafana/img/logo.png
grafana/img/practice_process_delivery_quality.png
grafana/img/4.png
grafana/img/jenkins.png
grafana/img/delivery_velocity.png
grafana/img/more.png
grafana/img/2.png
grafana/img/demo_quality.png
grafana/img/3.png
grafana/img/1.png
grafana/img/delivery_quality.png
img/wechat_community_barcode.png

Outstanding Questions @hezyin @klesh

  • ⚠️ Are we allowed to bundle Brand Logos (GitHub, JIRA etc.) with our release?
    • Feishu
    • GitHub
    • JIRA
    • GitLab
    • Jenkins

Target Release Branch
v0.11.0

Additional Branches
main

Does this close any open issues?

#2320

Screenshots

Screen Shot 2022-06-24 at 12 02 57 PM

Screen Shot 2022-06-24 at 12 03 34 PM

Screen Shot 2022-06-24 at 12 03 57 PM

@e2corporation e2corporation added pr-type/bug-fix This PR fixes a bug component/config-ui This issue or PR relates to config-ui labels Jun 24, 2022
@e2corporation e2corporation added this to the v0.11.0 milestone Jun 24, 2022
@e2corporation e2corporation self-assigned this Jun 24, 2022
@e2corporation e2corporation requested a review from klesh June 24, 2022 01:39
@e2corporation e2corporation marked this pull request as ready for review June 24, 2022 01:41
@e2corporation e2corporation changed the base branch from release-v0.11 to release-v0.11-hotfix June 24, 2022 14:26
@Startrekzky
Copy link
Contributor

Startrekzky commented Jun 24, 2022

Hi @e2corporation @mindlesscloud @klesh @yumengwang03 @WillemJiang , I've checked all following images in Grafana. They're all created by Wenfeng Piao, our designer. So I think the images listed below are fine.
As for the image 'img/wechat_community_barcode.png', I think it's the barcode for our Wechat community, which was generated by WeChat, so I think it's also OK legal-wise.

  • grafana/img/jira.png
  • grafana/img/delivery_cost.png
  • grafana/img/delivery_value.png
  • grafana/img/delivery_capability.png
  • grafana/img/gitlab.png
  • grafana/img/customer.png
  • grafana/img/practice_cross_domain.png
  • grafana/img/practice_process_delivery_velocity.png
  • grafana/img/trend.png
  • grafana/img/logo.png
  • grafana/img/practice_process_delivery_quality.png
  • grafana/img/4.png
  • grafana/img/jenkins.png
  • grafana/img/delivery_velocity.png
  • grafana/img/more.png
  • grafana/img/2.png
  • grafana/img/demo_quality.png
  • grafana/img/3.png
  • grafana/img/1.png
  • grafana/img/delivery_quality.png

Copy link
Contributor

@mindlesscloud mindlesscloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/config-ui This issue or PR relates to config-ui pr-type/bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants