[fix-2940][framework]: Add lazy caching of http codes for error handling and fix any broken Http error messages#2984
Merged
klesh merged 10 commits intoapache:mainfrom Sep 15, 2022
Merged
Conversation
b88e0f4 to
1697a90
Compare
4 tasks
3 tasks
ab04cb4 to
9d94c83
Compare
Contributor
Author
|
@klesh this is ready for review. I tuned things in accordance with the proposal here. cc @e2corporation |
Contributor
Author
Contributor
Author
|
Fix for #3031 screenshot: |
Contributor
Author
error status is now 400 like before. |
Contributor
Contributor
Author
|
@klesh Yes. |
ca240fa to
df7c3be
Compare
added 8 commits
September 14, 2022 18:24
…rrors better + addressed the issue in apache#3031
klesh
approved these changes
Sep 15, 2022
This was referenced Sep 15, 2022
3 tasks
This was referenced Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
{ "success": false, "message": "some string", "causes": ["cause1 string", "cause2 string", "cause3 string"] }Does this close any open issues?
Closes #2940, #3031
Screenshots
Other Information