fix: fix calculateSince out empty but not nil#3083
Merged
klesh merged 2 commits intoapache:mainfrom Sep 15, 2022
Merged
Conversation
mappjzc
force-pushed
the
github-fix
branch
2 times, most recently
from
e5eba74 to
0e7eca7
Compare
With latestUpdatedIssueComt.GithubId and latestUpdatedPrComt.GithubId was zero it will return 0. Nddtfjiang <zhicheng.jiang@merico.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With latestUpdatedIssueComt.GithubId and latestUpdatedPrComt.GithubId was zero it will return 0.
Does this close any open issues?
Closes #3054
Closes #3073
Screenshots
Other Information
Any other information that is important to this PR.