fix: update enrichTasksEnv params#3133
Merged
warren830 merged 6 commits intoapache:mainfrom Sep 20, 2022
Merged
Conversation
abeizn
force-pushed
the
enrich-env
branch
5 times, most recently
from
bb162cb to
fabfe94
Compare
warren830
reviewed
Sep 20, 2022
| pr.OrigReviewTimespan = int64(pr.MergedDate.Sub(*firstReviewTime).Minutes()) | ||
| } | ||
| deployTime, err := getDeployTime(repoId, data.Options.Environment, *pr.MergedDate, db) | ||
| deployTime, err := getDeployTime(repoId, devops.PRODUCTION, *pr.MergedDate, db) |
Contributor
There was a problem hiding this comment.
So we will never calculate devops.Staging?
abeizn
force-pushed
the
enrich-env
branch
2 times, most recently
from
7d70881 to
12ca91b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update environmentRegex to productionPattern, stagingPattern and testingPattern
Does this close any open issues?
related to #2876
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.