Add a snapshot structure and add commitLineChange table#3166
Merged
klesh merged 12 commits intoapache:mainfrom Sep 26, 2022
Merged
Add a snapshot structure and add commitLineChange table#3166klesh merged 12 commits intoapache:mainfrom
klesh merged 12 commits intoapache:mainfrom
Conversation
xgdyp
force-pushed
the
commit-snapshot
branch
from
4197499 to
abe8c27
Compare
Contributor
|
Hi, @xgdyp, thank you very much for the contribution. |
Contributor
Author
|
OK, now I'm fixing it. |
klesh
reviewed
Sep 23, 2022
Contributor
klesh
left a comment
klesh
left a comment
There was a problem hiding this comment.
Good job. please clean up the code:
- add
godocto all exported functions (those named in CamelCase convention) - remove unnecessary empty lines
- add an empty line between functions
- fix the golangci-lint errors
plugins/gitextractor/store/csv.go
Outdated
| } | ||
|
|
||
| func (c *CsvStore) CommitLineChange(commitLineChange *code.CommitLineChange) errors.Error { | ||
| return c.commitFileWriter.Write(commitLineChange) |
Contributor
There was a problem hiding this comment.
This is incorrect, different entities should be written to separate files.
I also notice the CommitFileComponents is writing to the commit_files.csv, please fix that as well.
xgdyp
force-pushed
the
commit-snapshot
branch
from
86e16a0 to
f947e94
Compare
xgdyp
force-pushed
the
commit-snapshot
branch
from
82c8257 to
bf1c4f9
Compare
Contributor
Author
|
hi @klesh , I've done these work. Please review it again,thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In This PR,I update a snapshot structure to store each commit code-snapshot.Using this structure,we can get some history message such as who is the previous author in each deleted line,how long do these deleted lines exist and so on.
Does this close any open issues?
related to #1771
Screenshots
This structure is similar to git-import tool in clickhouse repo
Other Information
Any other information that is important to this PR.