Skip to content

fix: fix sidebar href#3327

Merged
e2corporation merged 2 commits intoapache:mainfrom
merico-ai:issues/2994
Oct 12, 2022
Merged

fix: fix sidebar href#3327
e2corporation merged 2 commits intoapache:mainfrom
merico-ai:issues/2994

Conversation

@likyh
Copy link
Contributor

@likyh likyh commented Oct 8, 2022

Summary

fix href. Now it will not reload when click.

Does this close any open issues?

Closes #2994

@likyh likyh requested a review from mintsweet October 10, 2022 10:17
@likyh likyh requested review from e2corporation and removed request for mintsweet October 11, 2022 15:21
@e2corporation
Copy link
Contributor

@likyh PR is failing Lint Commit Message CI Check

Copy link
Contributor

@e2corporation e2corporation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e2corporation e2corporation merged commit ba31b96 into apache:main Oct 12, 2022
warren830 pushed a commit that referenced this pull request Oct 17, 2022
* fix: fix sidebar href

* fix: fix for review

Co-authored-by: linyh <yanghui@meri.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor][config-ui] reload when click any nav item

3 participants