Skip to content

feat: config-ui - register new providers azure bitbucket and gitee#3374

Merged
e2corporation merged 9 commits intoapache:mainfrom
merico-ai:jc-3373-ui-register-new-providers
Oct 18, 2022
Merged

feat: config-ui - register new providers azure bitbucket and gitee#3374
e2corporation merged 9 commits intoapache:mainfrom
merico-ai:jc-3373-ui-register-new-providers

Conversation

@e2corporation
Copy link
Contributor

@e2corporation e2corporation commented Oct 12, 2022

Config-UI / Data Provider Integrations 🆕

  • Azure
  • Bitbucket
  • Gitee
  • Add SVG Assets
  • Create & Register Transformation Settings Components
  • Update Data Sources List
  • Update Connection Manager All Connections List
  • Update Menu Configuration

Description

This PR registers new Data Providers Azure, BitBucket and Gitee on Configuration UI so feature development can continue. Additional changes to these provider settings will need to be made on related development tickets.

Does this close any open issues?

Closes #3373

Screenshots

Screen Shot 2022-10-11 at 11 16 26 PM

Screen Shot 2022-10-11 at 11 16 54 PM

Screen Shot 2022-10-11 at 11 17 02 PM

Screen Shot 2022-10-11 at 11 18 16 PM

@e2corporation e2corporation self-assigned this Oct 12, 2022
@e2corporation e2corporation added component/config-ui This issue or PR relates to config-ui pr-type/feature-development This PR is to develop a new feature labels Oct 12, 2022
@e2corporation e2corporation added this to the v0.15.0 milestone Oct 12, 2022
@e2corporation e2corporation changed the title feat: config-ui - register new providers azure bb and gitee feat: config-ui - register new providers azure bitbucket and gitee Oct 12, 2022
@e2corporation e2corporation force-pushed the jc-3373-ui-register-new-providers branch from d9d6291 to 6d5acf7 Compare October 12, 2022 05:25
@e2corporation e2corporation marked this pull request as ready for review October 12, 2022 05:26
@e2corporation e2corporation requested a review from klesh October 12, 2022 05:26
Copy link
Member

@mintsweet mintsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@likyh
Copy link
Contributor

likyh commented Oct 17, 2022

It looks like there will be some conflict with #3371. Let's do more changes only after these two PR merged.

@e2corporation e2corporation force-pushed the jc-3373-ui-register-new-providers branch from 6d5acf7 to 0bc2fef Compare October 18, 2022 13:30
@e2corporation e2corporation force-pushed the jc-3373-ui-register-new-providers branch from e269006 to acb7429 Compare October 18, 2022 13:31
@e2corporation
Copy link
Contributor Author

e2corporation commented Oct 18, 2022

@mintsweet Hello Junren, after this PR is merged, I'd like you to add some responsive tweaks to the Data Connections section to better accomodate the increased amount of providers displayed. on Larger Desktop 1 row is fine, however on Desktop/Tablet width 2 rows would be ideal.

(Desktop/Tablet Needs Optimization for multi-rows or wrapping)
Screen Shot 2022-10-18 at 9 38 37 AM

Screen Shot 2022-10-18 at 9 43 18 AM

(Existing design is optimal for Large/HD Desktop)

Screen Shot 2022-10-18 at 9 41 48 AM

@e2corporation e2corporation requested a review from likyh October 18, 2022 13:47
@e2corporation
Copy link
Contributor Author

@klesh @likyh This needs merge to main next to unblock related v0.15.0 milestone tasks.

Copy link
Contributor

@likyh likyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e2corporation e2corporation merged commit 1aee294 into apache:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/config-ui This issue or PR relates to config-ui pr-type/feature-development This PR is to develop a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Config-UI] Create Provider Configurations TAPD, BitBucket, Azure, GitEE

3 participants