Skip to content

fix: display curl in the webhook page#3406

Merged
Startrekzky merged 6 commits intoapache:mainfrom
merico-ai:fix/display-curl-in-webhook
Oct 13, 2022
Merged

fix: display curl in the webhook page#3406
Startrekzky merged 6 commits intoapache:mainfrom
merico-ai:fix/display-curl-in-webhook

Conversation

@likyh
Copy link
Copy Markdown
Contributor

@likyh likyh commented Oct 12, 2022

Summary

display curl in the webhook page

kBKVYCqVbG

The text copied is:

curl http://localhost:4000/api/plugins/webhook/1/deployments -X 'POST' -d "{
  \"repo_url\":\"$CIRCLE_REPOSITORY_URL\",
  \"commit_sha\":\"$CIRCLE_SHA1\",
  \"start_time\":\"$start_time\"
}"

@likyh likyh requested review from hezyin and removed request for hezyin October 12, 2022 16:07
@mintsweet
Copy link
Copy Markdown
Member

mintsweet commented Oct 13, 2022

@likyh The style of the url display is broken.

@likyh
Copy link
Copy Markdown
Contributor Author

likyh commented Oct 13, 2022

bDH3P7rcDM

@mintsweet
Copy link
Copy Markdown
Member

mintsweet commented Oct 13, 2022

LGTM.

@likyh
Copy link
Copy Markdown
Contributor Author

likyh commented Oct 13, 2022

image
fix some wording again.

mintsweet
mintsweet reviewed Oct 13, 2022
View reviewed changes
Comment thread config-ui/src/pages/connections/incoming-webhook/styled.js Outdated
padding: 0 10px;
height: 38px;
padding: 10px;
height: auto;
Copy link
Copy Markdown
Member

@mintsweet mintsweet Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property can not be set.

Copy link
Copy Markdown
Contributor Author

@likyh likyh Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mintsweet
Copy link
Copy Markdown
Member

mintsweet commented Oct 13, 2022

LGTM.

Startrekzky
Startrekzky approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Startrekzky Startrekzky merged commit 32ffc07 into apache:main Oct 13, 2022
likyh added a commit to merico-ai/lake that referenced this pull request Oct 13, 2022
@likyh
fix: display curl in the webhook page (apache#3406)
9906177 
* fix: display curl in webhook page

* fix: fix style

* fix: fix curl content

* fix: fix for lint

* fix: fix for review

* fix: fix for review

Co-authored-by: linyh <yanghui@meri.co>
This was referenced Oct 13, 2022
Closed
Merged
likyh added a commit that referenced this pull request Oct 13, 2022
@likyh
fix: display curl in the webhook page (#3406)
ed87146 
* fix: display curl in webhook page

* fix: fix style

* fix: fix curl content

* fix: fix for lint

* fix: fix for review

* fix: fix for review

Co-authored-by: linyh <yanghui@meri.co>
abeizn pushed a commit that referenced this pull request Oct 13, 2022
@likyh @abeizn
fix: display curl in the webhook page (#3406)
006cebb 
* fix: display curl in webhook page

* fix: fix style

* fix: fix curl content

* fix: fix for lint

* fix: fix for review

* fix: fix for review

Co-authored-by: linyh <yanghui@meri.co>
warren830 pushed a commit that referenced this pull request Oct 17, 2022
@likyh @warren830
fix: display curl in the webhook page (#3406)
926a3ba 
* fix: display curl in webhook page

* fix: fix style

* fix: fix curl content

* fix: fix for lint

* fix: fix for review

* fix: fix for review

Co-authored-by: linyh <yanghui@meri.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mintsweet mintsweet mintsweet left review comments

@Startrekzky Startrekzky Startrekzky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@likyh @mintsweet @Startrekzky