Skip to content

fix(framework): remove cicdPipelineRelationship#3687

Merged
warren830 merged 1 commit intoapache:mainfrom
merico-ai:3682-bugdomain-layer-unnecessary-tablecicd_pipeline_relationships
Nov 7, 2022
Merged

fix(framework): remove cicdPipelineRelationship#3687
warren830 merged 1 commit intoapache:mainfrom
merico-ai:3682-bugdomain-layer-unnecessary-tablecicd_pipeline_relationships

Conversation

@warren830
Copy link
Contributor

@warren830 warren830 commented Nov 7, 2022

Summary

I created cicd_pipeline_relationships by mistaken, so this pr is to do the following:

  1. remove model: CICDPipelineRelationship
  2. create migrationscript to delete table.cicd_pipeline_relationships which created in models/migrationscripts/20220905_modfiy_cicd_pipeline.go
  3. delete the code which insert data to table.cicd_pipeline_relationships

Does this close any open issues?

Closes #3682

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warren830 warren830 merged commit b4ba819 into apache:main Nov 7, 2022
@warren830 warren830 deleted the 3682-bugdomain-layer-unnecessary-tablecicd_pipeline_relationships branch November 7, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Domain Layer] Unnecessary table.cicd_pipeline_relationships

2 participants