Skip to content

fix: support github repository with dot(.) char#3695

Merged
likyh merged 1 commit intoapache:mainfrom
matrixji:bugfix-isses-3620
Nov 8, 2022
Merged

fix: support github repository with dot(.) char#3695
likyh merged 1 commit intoapache:mainfrom
matrixji:bugfix-isses-3620

Conversation

@matrixji
Copy link
Member

@matrixji matrixji commented Nov 8, 2022

Summary

fix pattern which matches repository name for the support repository name contains a dot

Does this close any open issues?

Closes #3620

Screenshots

after patched:
image

Other Information

N/A

fix pattern matches repository name contains a dot

Closes: apache#3620
Copy link
Contributor

@likyh likyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and is there any other char in name?

@likyh likyh merged commit 876e69b into apache:main Nov 8, 2022
@matrixji
Copy link
Member Author

matrixji commented Nov 8, 2022

LGTM, and is there any other char in name?

As repository names described:

All code points must be either a hyphen (-), an underscore (_), a period (.), or an ASCII alphanumeric code point

current pattern: /([a-z0-9_-]){2,}\/([.a-z0-9_-]){2,}$/gi should be OK for all cases.

And as Usernames, Organization names and Team names says dot(.) and dash(-) is not allowed. Actually, the pattern for the name part: ([a-z0-9_-]){2,} is more relaxed than what is actually needed. IMO, it is acceptable, as this pattern is just a filter for some basic checks on UI.

@matrixji matrixji deleted the bugfix-isses-3620 branch November 8, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][config-ui] Repository need support dot character(.)

2 participants