fix: support github repository with dot(.) char#3695
Merged
likyh merged 1 commit intoapache:mainfrom Nov 8, 2022
Merged
Conversation
3901cdb to
d67d791
Compare
fix pattern matches repository name contains a dot Closes: apache#3620
d67d791 to
91028ad
Compare
likyh
approved these changes
Nov 8, 2022
Contributor
likyh
left a comment
There was a problem hiding this comment.
LGTM, and is there any other char in name?
Member
Author
As repository names described:
current pattern: And as Usernames, Organization names and Team names says dot(.) and dash(-) is not allowed. Actually, the pattern for the name part: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix pattern which matches repository name for the support repository name contains a dot
Does this close any open issues?
Closes #3620
Screenshots
after patched:

Other Information
N/A