Skip to content

Feat(gitlab): set cicd_scope_id for cicd_tasks and cicd_pipelines#3716

Merged
warren830 merged 1 commit intoapache:mainfrom
merico-ai:feat-add-cicd-scope-id-gitlab
Nov 10, 2022
Merged

Feat(gitlab): set cicd_scope_id for cicd_tasks and cicd_pipelines#3716
warren830 merged 1 commit intoapache:mainfrom
merico-ai:feat-add-cicd-scope-id-gitlab

Conversation

@warren830
Copy link
Contributor

@warren830 warren830 commented Nov 10, 2022

Summary

This pr is simple, similar to #3707 #3715

  1. convert repo to cicd_scope
  2. set cicd_scope_id to cicd_tasks and cicd_pipelines
  3. update e2e

Does this close any open issues?

closes #3699

Screenshots

image
2.
image
image

Other Information

Any other information that is important to this PR.

likyh
likyh previously approved these changes Nov 10, 2022
Copy link
Contributor

@likyh likyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if e2e passed

@warren830 warren830 force-pushed the feat-add-cicd-scope-id-gitlab branch 2 times, most recently from 6d4b532 to b56ab87 Compare November 10, 2022 12:38
@warren830 warren830 force-pushed the feat-add-cicd-scope-id-gitlab branch from b56ab87 to 945b78c Compare November 10, 2022 12:44
@warren830 warren830 merged commit 9e3d1ba into apache:main Nov 10, 2022
@warren830 warren830 deleted the feat-add-cicd-scope-id-gitlab branch November 10, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][CICD] Add cicd_scope_id for tasks/pipelines

3 participants