Merged
Conversation
likyh
commented
Nov 14, 2022
| }, []) | ||
|
|
||
| const fetchAllPipelines = useCallback((status = null, fetchTimeout = 500) => { | ||
| const fetchAllPipelines = useCallback((blueprintId, status = null, fetchTimeout = 500) => { |
likyh
commented
Nov 14, 2022
| } | ||
| }, []) | ||
|
|
||
| const fetchPipeline = useCallback((pipelineID, refresh = false) => { |
Contributor
Author
There was a problem hiding this comment.
refresh hasn't been used and I don't know what it means. so it has been deleted.
likyh
commented
Nov 14, 2022
|
|
||
| useEffect(() => { | ||
| setActiveStage(stages[sK]) | ||
| console.log('>> ACTIVE STAGE LANE', stages[sK]) |
likyh
commented
Nov 14, 2022
| fetchPipeline(activePipeline?.id) | ||
| // setLastPipeline(activePipeline) | ||
| }, pollTimer) | ||
| return () => { |
Contributor
Author
There was a problem hiding this comment.
related to #3640.
add a return func to cancel setInterval.
likyh
commented
Nov 14, 2022
| ...cR, | ||
| startedAt: activePipeline?.beganAt | ||
| ? dayjs(activePipeline?.beganAt).format('L LTS') | ||
| id: activePipeline.id, |
Contributor
Author
There was a problem hiding this comment.
related to #3522.
delete lastPipeline and replace with activePipeline
mintsweet
approved these changes
Nov 15, 2022
|
|
||
| useEffect(() => { | ||
| setActiveStage(stages[sK]) | ||
| console.log('>> ACTIVE STAGE LANE', stages[sK]) |
klesh
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summary write at comments
Does this close any open issues?
Closes #3733
Closes #3640
Closes #3522
Closes #3490