Skip to content

refactor: unify all apiclient creation for all plugins#4346

Merged
mindlesscloud merged 2 commits intoapache:mainfrom
merico-ai:kw-4298-otherapiclient
Feb 7, 2023
Merged

refactor: unify all apiclient creation for all plugins#4346
mindlesscloud merged 2 commits intoapache:mainfrom
merico-ai:kw-4298-otherapiclient

Conversation

@klesh
Copy link
Contributor

@klesh klesh commented Feb 7, 2023

Summary

unify all apiclient creation for all plugins

Does this close any open issues?

Closes #4298

Screenshots

bitbucket-blueprint-normalmode
bitbucket-blueprint-normalmode

gitee-blueprint-normalmode
gitee-blueprint-normalmode

github-blueprint-normalmode
github-blueprint-normalmode

github-proxy
github-proxy

gitlab-blueprint-normalmode
gitlab-blueprint-normalmode

gitlab-blueprint-normalmode-v2
gitlab-blueprint-normalmode-v2

gitlab-proxy
gitlab-proxy

jenkins-blueprint-normalmode
jenkins-blueprint-normalmode

jira-proxy
jira-proxy

make-test
make-test

Copy link
Contributor

@mindlesscloud mindlesscloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindlesscloud mindlesscloud merged commit 145431a into apache:main Feb 7, 2023
warren830 pushed a commit to merico-ai/lake that referenced this pull request Feb 7, 2023
* refactor: unify all apiclient creation for all plugins

* fix: linting
likyh pushed a commit to merico-ai/lake that referenced this pull request Feb 10, 2023
* refactor: unify all apiclient creation for all plugins

* fix: linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor][apihelper] Simplify and Unify ApiClient Creation Logic

2 participants