feat: add pipeline step for bitbucket#4459
Merged
warren830 merged 2 commits intoapache:mainfrom Feb 20, 2023
Merged
Conversation
likyh
commented
Feb 20, 2023
| Type string `gorm:"type:varchar(255)"` | ||
| Name string `gorm:"type:varchar(255)"` | ||
| Environment string `gorm:"type:varchar(255)"` | ||
| EnvironmentType string `gorm:"type:varchar(255)"` |
Contributor
Author
There was a problem hiding this comment.
add StepId / Environment / EnvironmentType
warren830
reviewed
Feb 20, 2023
| Generate(data.Options.ConnectionId, bitbucketDeployment.Name), | ||
| PipelineId: bitbucketDeployment.PipelineId, | ||
| Name: bitbucketPipelineStep.Name, | ||
| PipelineId: bitbucketPipelineStep.PipelineId, |
Contributor
There was a problem hiding this comment.
we should use domain if of cicd pipeline
warren830
requested changes
Feb 20, 2023
Contributor
warren830
left a comment
warren830
left a comment
There was a problem hiding this comment.
A minor issue need to be fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page,pagelen,sizeto fix a bug(to collect all page).Does this close any open issues?
Closes #4340
Screenshots
Result like this: