refactor: refactor starrocks, improve performance, solve bugs#4475
Merged
abeizn merged 7 commits intoapache:mainfrom Feb 23, 2023
Merged
refactor: refactor starrocks, improve performance, solve bugs#4475abeizn merged 7 commits intoapache:mainfrom
abeizn merged 7 commits intoapache:mainfrom
Conversation
klesh
reviewed
Feb 23, 2023
| } | ||
| } | ||
| // 2. Filter out the tables to import | ||
| starrocksTables, err := getImportTables(c, db) |
Contributor
There was a problem hiding this comment.
import? I think it should be export?
| var orderBy string | ||
| var skip bool | ||
| columnMap, orderBy, skip, err = createTmpTable(starrocks, db, starrocksTable, starrocksTmpTable, table, c, config) | ||
| columnMap, orderBy, skip, err := createTmpTable(c, starrocksDb, db, starrocksTable, starrocksTmpTable, table) |
Contributor
There was a problem hiding this comment.
How about createTmpTableInStarrocks?
| return errors.Convert(err) | ||
| } | ||
| err = errors.Convert(db.Exec("commit")) | ||
| err = putDataToDst(c, starrocksDb, db, starrocksTable, starrocksTmpTable, table, columnMap, orderBy) |
abeizn
force-pushed
the
starrocks-refactor
branch
from
8c5700e to
f854025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor starrocks, improve performance, solve bugs.
Does this close any open issues?
Closes #4418
Closes #4376
Closes #4377
Screenshots
export data:
cancel task:
pipeline is blocked for 30+ mins：
Other Information
Any other information that is important to this PR.