Merged
Conversation
CamilleTeruel
force-pushed
the
blueprint_v200_py_plugins
branch
2 times, most recently
from
e0e7209 to
7400bcd
Compare
A stream must declare its domain types ("CICD", "TICKET", "CROSS", etc), not the domain model it produces.
…tV200 A remoteDatasourcePlugin struct as a PluginMeta must be castable to DataSourcePluginBlueprintV200.
Make Plugin inherit ABC to ensure all abstract methods are implemented by subclasses.
Not all plugins need transformation rules, so we make it optional.
Even if connections and transformation rules are sent from go to python, they are also models backed by a tool table.
Now that we receive a Connection with its id, we don't need separate connection_id in Context.
…mand Use the genuine tool scopes as input and genuine domain scopes as output to the make-pipeline command. For tool scope inputs, python plugins are oblivious of the BlueprintScope concept, the go side taking care of fetching and passing the real tool scopes. For the domain scope outputs, it requires to send back the domain scope as a json object together with a type name to allow reconstruction on go side. Because of limited go reflective abilities, the reconstruction function hardcodes the existing domain scope types.
Python plugins now support a two level scope hierarchy: scopes and scope groups. When the group_id query parameter is absent, the default implementation calls `remote_scope_groups` that is redefined in each plugin. If the group_id is given, the default implementation call `remote_scopes` that return the scopes that are in a given group id.
CamilleTeruel
force-pushed
the
blueprint_v200_py_plugins
branch
2 times, most recently
from
4cd3eb6 to
a8d2ddf
Compare
Contributor
|
Relates to #4450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
Does this close any open issues?
Closes xx
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.