Skip to content

fix: expand project key to 255#4744

Merged
mindlesscloud merged 1 commit intoapache:mainfrom
merico-ai:issues/4716
Mar 22, 2023
Merged

fix: expand project key to 255#4744
mindlesscloud merged 1 commit intoapache:mainfrom
merico-ai:issues/4716

Conversation

@likyh
Copy link
Contributor

@likyh likyh commented Mar 22, 2023

Summary

expand project key to 255

This pr will cherry-pick to 0.16

Does this close any open issues?

Closes #4716

image

Copy link
Contributor

@mindlesscloud mindlesscloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindlesscloud mindlesscloud merged commit 1d3cd9a into apache:main Mar 22, 2023
@warren830 warren830 deleted the issues/4716 branch March 22, 2023 13:33
@aubertaa
Copy link

@mindlesscloud
Hi,
it seems that this PR has not been cherry picked to 0.16 as announced : i'm still facing the issue with 0.16.0-beta11 and i've seen that the code still mention 64 as max length of DB field.
Could you please make it available in next 0.16 release ?
Regards,

abeizn pushed a commit that referenced this pull request Apr 17, 2023
@hezyin
Copy link
Contributor

hezyin commented Apr 18, 2023

Hi @aubertaa, the fix has been released with https://github.com/apache/incubator-devlake/releases/tag/v0.16.0-beta15. Thanks again for reporting this bug.

warren830 added a commit that referenced this pull request Apr 19, 2023
* fix: move extract existing graphql data to general position (#4921)

Co-authored-by: abeizn <zikuan.an@merico.dev>

* fix(release): add skip binlog for mysql (#4798)

* fix: the jql time zone issue (#4932)

* fix: customize refers to the code of jira (#4936) (#4940)

* fix: expand project key to 255 (#4744)

* fix: Downgrade Python to 3.9 to support dbt plugin (#4946)

* fix: cherry pick #4947 (#4950)

* Cherrypick #4912 #4913 to release-v0.16 for hexun (#4919)

* cp(tapd): cherrypick #4913 to v0.16 for hexun

* feat(tapd): add custom field enricher (#4912)

* fix(tapd): fix raw data args

* cp(tapd): cherrypick #4913 to v0.16 for hexun (#4920)

---------

Co-authored-by: Likyh <yanghui@meri.co>
Co-authored-by: abeizn <zikuan.an@merico.dev>
Co-authored-by: Liang Zhang <liang.zhang@merico.dev>
Co-authored-by: Keon Amini <keon.amini@merico.dev>
warren830 added a commit that referenced this pull request Apr 19, 2023
* fix: move extract existing graphql data to general position (#4921)

Co-authored-by: abeizn <zikuan.an@merico.dev>

* fix(release): add skip binlog for mysql (#4798)

* fix: the jql time zone issue (#4932)

* fix: customize refers to the code of jira (#4936) (#4940)

* fix: expand project key to 255 (#4744)

* fix: Downgrade Python to 3.9 to support dbt plugin (#4946)

* fix: cherry pick #4947 (#4950)

* Cherrypick #4912 #4913 to release-v0.16 for hexun (#4919)

* cp(tapd): cherrypick #4913 to v0.16 for hexun

* feat(tapd): add custom field enricher (#4912)

* fix(tapd): fix raw data args

* cp(tapd): cherrypick #4913 to v0.16 for hexun (#4920)

---------

Co-authored-by: Likyh <yanghui@meri.co>
Co-authored-by: abeizn <zikuan.an@merico.dev>
Co-authored-by: Liang Zhang <liang.zhang@merico.dev>
Co-authored-by: Keon Amini <keon.amini@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Sonarqube plugin] Error 500 on trying to add too many projects

4 participants