Refactor Chage Lead Time - Step 3: convert bitbucket deployment to domain layer#4894
Merged
mindlesscloud merged 4 commits intoapache:mainfrom Apr 12, 2023
Merged
Conversation
|
|
||
| var duration *uint64 | ||
| if bitbucketDeployment.CompletedOn != nil { | ||
| d := uint64(bitbucketDeployment.CompletedOn.Sub(*bitbucketDeployment.StartedOn).Seconds()) |
Contributor
There was a problem hiding this comment.
Do we need to check if bitbucketDeployment.StartedOn is null?
Contributor
Author
There was a problem hiding this comment.
It makes no sense for StartedOn to be nil when CompleteOn is not .
mindlesscloud
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetStatusreturning FAILURE when it should be DONEdeployment_commitstable for tracking deployments on repository/commits levelDeploymentConvertorto bitbucket pluginThis PR convers the following scenario from the flow chart in #4869

Does this close any open issues?
Part of #4869
Screenshots
After collect data from https://bitbucket.org/likyh/likyhphp
And using the following SQL
I got the following result:
Other Information
Any other information that is important to this PR.