Skip to content

Refactor Chage Lead Time - Step 5: enrich cicd_deployment_commits.prev_success_deployment_commit_id#4922

Merged
mindlesscloud merged 6 commits intoapache:mainfrom
merico-ai:kw-4869-dora-refactor
Apr 14, 2023
Merged

Refactor Chage Lead Time - Step 5: enrich cicd_deployment_commits.prev_success_deployment_commit_id#4922
mindlesscloud merged 6 commits intoapache:mainfrom
merico-ai:kw-4869-dora-refactor

Conversation

@klesh
Copy link
Contributor

@klesh klesh commented Apr 13, 2023

Summary

  1. added DataEnricher helper to support Cancellation and BatchSave
  2. fixed some minor problems
  3. added prev_deployment_commit_enricher to connect consecutive deployments
  4. added e2e test for prev_deployment_commit_enricher

Next step: calculate commits_diffs for deployment_commits

Does this close any open issues?

Part of #4869

Screenshots

Before enrichment
image
source: https://github.com/apache/incubator-devlake/blob/440457d4a6a5d4d94a37903fde0457df816d83b8/backend/plugins/dora/e2e/prev_success_deployment_commit/cicd_deployment_commits_before.csv
After enrichment
image
source: https://github.com/apache/incubator-devlake/blob/440457d4a6a5d4d94a37903fde0457df816d83b8/backend/plugins/dora/e2e/prev_success_deployment_commit/cicd_deployment_commits_after.csv

Copy link
Contributor

@mindlesscloud mindlesscloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindlesscloud mindlesscloud merged commit 49fc227 into apache:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants