Skip to content

feat: enrich cicd_pipeline type/env for jenkins#4959

Merged
abeizn merged 1 commit intoapache:mainfrom
merico-ai:kw-4869-dora-refactor-jenkins
Apr 23, 2023
Merged

feat: enrich cicd_pipeline type/env for jenkins#4959
abeizn merged 1 commit intoapache:mainfrom
merico-ai:kw-4869-dora-refactor-jenkins

Conversation

@klesh
Copy link
Contributor

@klesh klesh commented Apr 19, 2023

Summary

Previously cicd_pipelines that converted from jenkins builds didn't fill in the type/env fields.
This PR would do so, along with other small refactors

Does this close any open issues?

Related to #4869

@abeizn abeizn force-pushed the kw-4869-dora-refactor-jenkins branch from 93bece6 to d4637a3 Compare April 23, 2023 03:21
Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abeizn abeizn merged commit bff2ef9 into apache:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments