Skip to content

cherry-pick: fix jenkins stage convertor error (#5003)#5044

Merged
klesh merged 1 commit intoapache:release-v0.16from
leric:cp/fix-jenkins-data
Apr 27, 2023
Merged

cherry-pick: fix jenkins stage convertor error (#5003)#5044
klesh merged 1 commit intoapache:release-v0.16from
leric:cp/fix-jenkins-data

Conversation

@leric
Copy link
Contributor

@leric leric commented Apr 27, 2023

  • fix: fix jenkins stage convertor error

  • all stage env is set to production when ProductionPattern is not set

  • stage status is set to IN_PROGRESS when task status is not SUCCESS

  • fix: cicd_scopes is empty

  • fix: unittest

Summary

cherry-pick bug fix PR #5003 to release-0.16

Does this close any open issues?

Closes xx

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@leric leric marked this pull request as ready for review April 27, 2023 03:03
{
Plugin: "refdiff",
Subtasks: []string{"calculateProjectDeploymentCommitsDiff"},
Subtasks: []string{"calculateDeploymentCommitsDiff"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculateDeploymentCommitsDiff does not exist in v0.16

* fix: fix jenkins stage convertor error

* all stage env is set to production when ProductionPattern is not set
* stage status is set to IN_PROGRESS when task status is not SUCCESS

* fix: cicd_scopes is empty

* fix: unittest
@leric leric force-pushed the cp/fix-jenkins-data branch from dab03e5 to 3f2c6de Compare April 27, 2023 03:07
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 90206f3 into apache:release-v0.16 Apr 27, 2023
@leric leric deleted the cp/fix-jenkins-data branch May 23, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants