Merged
Conversation
CamilleTeruel
force-pushed
the
5159_ScopeConfig_pydevlake
branch
from
2a13a15 to
3aaf65f
Compare
Contributor
|
@CamilleTeruel Seems like the test failed, can you fix them first? Thanks. |
CamilleTeruel
force-pushed
the
5159_ScopeConfig_pydevlake
branch
from
3aaf65f to
2c2a2a7
Compare
CamilleTeruel
force-pushed
the
5159_ScopeConfig_pydevlake
branch
2 times, most recently
from
2a8dbf1 to
cc26115
Compare
CamilleTeruel
force-pushed
the
5159_ScopeConfig_pydevlake
branch
from
cc26115 to
3941371
Compare
keon94
reviewed
Jun 6, 2023
keon94
reviewed
Jun 6, 2023
CamilleTeruel
force-pushed
the
5159_ScopeConfig_pydevlake
branch
6 times, most recently
from
0c30b0b to
549ed88
Compare
Contributor
|
There are some merge conflicts, otherwise LGTM. |
keon94
previously approved these changes
Jun 7, 2023
CamilleTeruel
force-pushed
the
5159_ScopeConfig_pydevlake
branch
6 times, most recently
from
929e173 to
926e204
Compare
added 3 commits
June 7, 2023 10:44
TransformationRule is renamed ScopeConfig and now includes domain types.
CamilleTeruel
force-pushed
the
5159_ScopeConfig_pydevlake
branch
from
926e204 to
5259b91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename TransformationRule to ScopeConfig that also includes domain types.
Does this close any open issues?
Part of #5159