fix: sonar issue collector time range split #5443
Merged
mappjzc merged 1 commit intoapache:mainfrom Jun 13, 2023
Merged
Conversation
leric
force-pushed
the
fix/sonar-issue-collector
branch
from
f7029d2 to
4440262
Compare
mappjzc
approved these changes
Jun 13, 2023
This was referenced Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sonarqube issue collector will split result of issues/search by using createdBefore & createdAfter filter params, if the result exceed 100 pages.
The split end when createdBefore - createdAfter less than 1 second, which is createdBefore == createdAfter, and sonarqube api do not allow createdBefore and createdAfter to be equal. In some case sonar scanner failed to do backdating, all issues have same createdTime, the split will end up createdBefore == createdAfter, and fail with sonarqube api error.
This time range spliting don't need to be so acurate, this PR change the end condition to 10 seconds.
Does this close any open issues?
Closes #5442
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.