fix: Support explicit auto-increment fields in Python#5785
Merged
CamilleTeruel merged 1 commit intoapache:mainfrom Aug 1, 2023
Merged
fix: Support explicit auto-increment fields in Python#5785CamilleTeruel merged 1 commit intoapache:mainfrom
CamilleTeruel merged 1 commit intoapache:mainfrom
Conversation
keon94
force-pushed
the
fix-python-autoincrement
branch
from
0f71d1b to
ea051e6
Compare
keon94
force-pushed
the
fix-python-autoincrement
branch
from
ea051e6 to
cc7e94d
Compare
keon94
added
component/pydevlake
CamilleTeruel
approved these changes
Aug 1, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do?
Adds support for user-defined auto-increment fields. Need arose from a bug caused by having composite keys with default auto-increment set to on. See https://gorm.io/docs/composite_primary_key.html.
The Builds model of AzureDevops now defines auto-inc to be False for ID. ConnectionID in all tool structs will have it set to false as well. This was the error we were getting earlier:
Does this close any open issues?
Closes n/a
Caused by #5746
Screenshots
Other Information
Any other information that is important to this PR.