Fix 6112

[Marco-De-Stefani]

Summary

Fixing #6112 and removing the typo in the version of golangci-lint

Does this close any open issues?

Closes #6112

Screenshots

Before:

After:

[keon94]

Has PagerDuty made this change to their API recently? How come this wasn't an issue before?

[Marco-De-Stefani]

@keon94 I think that Pagerduty API has not been changed, by having a quick look at the GH history I believe this has been introduced with the refactor of the Pagerduty plugin.
It looks to me that the first version of the plugin implemented in the revision eef06e9 uses the correct token.
In that revision, the connection.go file contains -->
Token string mapstructure:"token" env:"PAGERDUTY_AUTH" validate:"required" encrypt:"yes"

[keon94]

@Marco-De-Stefani very odd. I tried running the pagerduty tests under test/e2e/manual/pagerduty with and without this change and it works for me, so I don't know what's going on. Either way, there's a better fix for this which I've pointed out in the file changes.

[Marco-De-Stefani]

@Marco-De-Stefani very odd. I tried running the pagerduty tests under test/e2e/manual/pagerduty with and without this change and it works for me, so I don't know what's going on. Either way, there's a better fix for this which I've pointed out in the file changes.

I noticed that as well, it works cause at line 125 of the pagerduty_test.go file it's calling "PagerDutyAccessToken" which sets the token in the correct way :)

[keon94]

@Marco-De-Stefani very odd. I tried running the pagerduty tests under test/e2e/manual/pagerduty with and without this change and it works for me, so I don't know what's going on. Either way, there's a better fix for this which I've pointed out in the file changes.

I noticed that as well, it works cause at line 125 of the pagerduty_test.go file it's calling "PagerDutyAccessToken" which sets the token in the correct way :)

That token object doesn't have an influence here though. The test still passes without "token=". Here's what my debugger captures - connection.Token is just the raw token.

[Marco-De-Stefani]

@Marco-De-Stefani very odd. I tried running the pagerduty tests under test/e2e/manual/pagerduty with and without this change and it works for me, so I don't know what's going on. Either way, there's a better fix for this which I've pointed out in the file changes.

I noticed that as well, it works cause at line 125 of the pagerduty_test.go file it's calling "PagerDutyAccessToken" which sets the token in the correct way :)

That token object doesn't have an influence here though. The test still passes without "token=". Here's what my debugger captures - connection.Token is just the raw token.

Weird, I'll try to debug that as well

[keon94]

LGTM

[klesh]

Hi, Nice work, thanks for your contribution, would you like to cherry-pick it back to release v0.19?