Refine .clang-format

[gaodayue]

Part of #2790

The goal is to

1. Choose the most popular style options based on existing code, in order to minimize reformatting diffs
2. Remove options that are same with Google, to make it clear the differences between Doris's style and Google's

[gaodayue]

FYI @vagetablechicken

[vagetablechicken]

is it ok with SortIncludes diffs? It's true in Google style.

[gaodayue]

is it ok with SortIncludes diffs? It's true in Google style.

Hi @vagetablechicken , thanks for the reply. I've tried using this file to reformat existing code, it turns out that the majority of diffs are not caused by SortIncludes, but ColumnLimit instead.

Clang-format will try to put as many arguments as possible into the the same line if ColumnLimit is not reached or insert breaks otherwise. For example

-    _create_tablet_workers = new TaskWorkerPool(
-            TaskWorkerPool::TaskWorkerType::CREATE_TABLE,
-            _exec_env,
-            master_info);
-    _drop_tablet_workers = new TaskWorkerPool(
-            TaskWorkerPool::TaskWorkerType::DROP_TABLE,
-            _exec_env,
-            master_info);
-    _push_workers = new TaskWorkerPool(
-            TaskWorkerPool::TaskWorkerType::PUSH,
-            _exec_env,
-            master_info);
-    _publish_version_workers = new TaskWorkerPool(
-            TaskWorkerPool::TaskWorkerType::PUBLISH_VERSION,
-            _exec_env,
-            master_info);
+    _create_tablet_workers = new TaskWorkerPool(TaskWorkerPool::TaskWorkerType::CREATE_TABLE,
+                                                _exec_env, master_info);
+    _drop_tablet_workers =
+            new TaskWorkerPool(TaskWorkerPool::TaskWorkerType::DROP_TABLE, _exec_env, master_info);
+    _push_workers =
+            new TaskWorkerPool(TaskWorkerPool::TaskWorkerType::PUSH, _exec_env, master_info);
+    _publish_version_workers = new TaskWorkerPool(TaskWorkerPool::TaskWorkerType::PUBLISH_VERSION,
+                                                  _exec_env, master_info);

Another major diff is caused by AlignAfterOpenBracket. For example with AlignAfterOpenBracket set to Align

-void TaskWorkerPool::_alter_tablet(
-        TaskWorkerPool* worker_pool_this,
-        const TAgentTaskRequest& agent_task_req,
-        int64_t signature,
-        const TTaskType::type task_type,
-        TFinishTaskRequest* finish_task_request) {
+void TaskWorkerPool::_alter_tablet(TaskWorkerPool* worker_pool_this,
+                                   const TAgentTaskRequest& agent_task_req, int64_t signature,
+                                   const TTaskType::type task_type,
+                                   TFinishTaskRequest* finish_task_request) {

However I can't find a way to allow multiple align styles. Seems that one style must be chosen and Align is widely used and looks good to me.

[vagetablechicken]

That's nice, I prefer sorting includes.

[imay]

LGTM