[GLUTEN-7283][CORE] Support DynamicPruningExpression conversion#7284
Merged
zhztheplayer merged 5 commits intoapache:mainfrom Sep 26, 2024
Merged
[GLUTEN-7283][CORE] Support DynamicPruningExpression conversion#7284zhztheplayer merged 5 commits intoapache:mainfrom
zhztheplayer merged 5 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI |
3 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Member
Author
|
@zhztheplayer @PHILO-HE Could you please take a look? |
PHILO-HE
previously approved these changes
Sep 23, 2024
wForget
force-pushed
the
GLUTEN-7283
branch
from
dbfa671 to
3e75fa2
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
zhztheplayer
approved these changes
Sep 24, 2024
Member
zhztheplayer
left a comment
zhztheplayer
left a comment
There was a problem hiding this comment.
What's the real use case of ChildTransformer? Can we just remove it?
cc @zzcclp
Member
Author
I have the same confusion, it seems to be just a placeholder. If it's no longer needed I'll open a new PR to remove it. |
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
|
is this change consumed by velox? i can't seem to find any references to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support DynamicPruningExpression conversion
Fixes: #7283
How was this patch tested?
added unit test