[LIMINAL-5] change prints to log #10
Conversation
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| import json | ||
| import os |
There was a problem hiding this comment.
Why were these changes made to hello_world.py?
There was a problem hiding this comment.
The commented lines seemed redundant since they are not in use. if they are needed - my bad.
|
|
||
| import logging | ||
| from liminal.core import environment | ||
| LIMINAL = 'liminal' |
There was a problem hiding this comment.
make sure file passes PEP8
If you use an IDE like PyCharm / IntelliJ it can help you format the file
There was a problem hiding this comment.
Seems OK on my end. Actually there are existing files that seem to need an adjustment.
| LOGS_DIR = 'logs' | ||
|
|
||
| def logging_initialization(): | ||
| # TBD - rotating file handler |
There was a problem hiding this comment.
I see these are still TBD
Currently I'm not seeing the log lines in sysout or in logs file
I think for now let's just focus on sysout and not log to file
There was a problem hiding this comment.
There was a problem hiding this comment.
The TBDs are for future reference/work, I can remove them if you prefer.
|
Merged in #19 |
2 participants
No description provided.