Added .codecov.yml to support monorepo like structure to report cover…#35
Added .codecov.yml to support monorepo like structure to report cover…#35tallandroid wants to merge 5 commits intoapache:developfrom tallandroid:MARVIN-43
Conversation
…age for engine executor and python-toolbox
Codecov Report
@@ Coverage Diff @@
## develop #35 +/- ##
========================================
Coverage 70.92% 70.92%
========================================
Files 26 26
Lines 2198 2198
Branches 226 226
========================================
Hits 1559 1559
Misses 618 618
Partials 21 21Continue to review full report at Codecov.
|
|
From the codecov report above, it still only get the python part. Not sure if it is because there is no code change? |
…age for engine executor and python-toolbox
- Added .codecov.yml to support monorepo like structure to report coverage for engine executor and python-toolbox - Started reporting the coverage for scala during travis build
|
Ok , so i have tried multiple configurations. The core problem was travis not uploading the configuration. Adding flags do help to segregate coverage between python and scala. It can be found here : https://codecov.io/gh/tallandroid/incubator-marvin/branch/MARVIN-43 That being said, travis is executing build target for python toolbox twice for some reason by design. Ill go ahead and discard this PR for now. Ill open a new PR for just reporting sbt coverage along with python coverage without the flags for now. But this needs to be fixed going forward. |
|
Thanks for the investigation and discovery! |
Added .codecov.yml based on the flag support for https://docs.codecov.io/docs/flags. I have validated the configuration but cant test it with the original repo as I dont have the repo token :
Validation Output:
Could the repo owners help with testing the configuration