Skip to content
This repository was archived by the owner on Mar 9, 2023. It is now read-only.

Added .codecov.yml to support monorepo like structure to report cover…#35

Closed
tallandroid wants to merge 5 commits intoapache:developfrom
tallandroid:MARVIN-43
Closed

Added .codecov.yml to support monorepo like structure to report cover…#35
tallandroid wants to merge 5 commits intoapache:developfrom
tallandroid:MARVIN-43

Conversation

@tallandroid
Copy link
Copy Markdown

Added .codecov.yml based on the flag support for https://docs.codecov.io/docs/flags. I have validated the configuration but cant test it with the original repo as I dont have the repo token :

Validation Output:

➜  incubator-marvin git:(MARVIN-43) ✗ curl --data-binary @.codecov.yml https://codecov.io/validate
Valid!

{
  "flags": {
    "projectA": {
      "paths": [
        "^engine-executor/src.*"
      ]
    },
    "projectB": {
      "paths": [
        "^python-toolbox/marvin_python_toolbox.*"
      ]
    }
  },
  "coverage": {
    "status": {
      "project": {
        "default": {
          "threshold": null,
          "target": 70.0
        },
        "engine-executor": {
          "flags": [
            "engine-executor"
          ],
          "target": 50.0
        },
        "python-toolbox": {
          "flags": [
            "python-toolbox"
          ],
          "target": 70.0
        }
      }
    }
  }
}

Could the repo owners help with testing the configuration

…age for engine executor and python-toolbox
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 1, 2019

Codecov Report

Merging #35 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #35   +/-   ##
========================================
  Coverage    70.92%   70.92%           
========================================
  Files           26       26           
  Lines         2198     2198           
  Branches       226      226           
========================================
  Hits          1559     1559           
  Misses         618      618           
  Partials        21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff33b2...59e81f8. Read the comment docs.

@Wei-1
Copy link
Copy Markdown
Member

Wei-1 commented Oct 1, 2019

From the codecov report above, it still only get the python part. Not sure if it is because there is no code change?

Harshit Rohatgi and others added 4 commits September 30, 2019 23:57
…age for engine executor and python-toolbox
- Added .codecov.yml to support monorepo like structure to report coverage for engine executor and python-toolbox
- Started reporting the coverage for scala during travis build
@tallandroid
Copy link
Copy Markdown
Author

Ok , so i have tried multiple configurations. The core problem was travis not uploading the configuration. Adding flags do help to segregate coverage between python and scala.

It can be found here : https://codecov.io/gh/tallandroid/incubator-marvin/branch/MARVIN-43

That being said, travis is executing build target for python toolbox twice for some reason by design. Ill go ahead and discard this PR for now.

Ill open a new PR for just reporting sbt coverage along with python coverage without the flags for now. But this needs to be fixed going forward.

@tallandroid tallandroid closed this Oct 1, 2019
@tallandroid tallandroid deleted the MARVIN-43 branch October 1, 2019 09:02
@Wei-1
Copy link
Copy Markdown
Member

Wei-1 commented Oct 1, 2019

Thanks for the investigation and discovery!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants