Skip to content
This repository was archived by the owner on Feb 16, 2024. It is now read-only.

[S2GRAPH-40] PostProcess.toHashKey gives different hash key with same value when edge's label schema version is different.#23

Closed
SteamShon wants to merge 1 commit intoapache:masterfrom
SteamShon:S2GRAPH-40
Closed

[S2GRAPH-40] PostProcess.toHashKey gives different hash key with same value when edge's label schema version is different.#23
SteamShon wants to merge 1 commit intoapache:masterfrom
SteamShon:S2GRAPH-40

Conversation

@SteamShon
Copy link
Copy Markdown
Contributor

@SteamShon SteamShon commented Feb 19, 2016

  • use toString rather hashCode on different version of InnerVal
  • v1 and v2 InnerVal use different bytes encoding scheme.

@SteamShon
S2GRAPH-40 PostProcess.toHashKey gives different hash key with same v…
542e890 
…alue when edge's label schema version is different.

use toString of innerVal to deal with different bytes scheme between v1 and v2.
@em3s
Copy link
Copy Markdown
Contributor

em3s commented Feb 20, 2016

+1

2 similar comments
@daewon
Copy link
Copy Markdown
Contributor

daewon commented Feb 20, 2016

+1

@elric-k
Copy link
Copy Markdown
Contributor

elric-k commented Feb 23, 2016

+1

@asfgit asfgit closed this in 5ac470e Feb 23, 2016
HyunsungJo pushed a commit to HyunsungJo/incubator-s2graph that referenced this pull request Jun 14, 2016
Merge pull request apache#23 from Graph/ISSUE-10
4bedf2a 
[ISSUE-10]: Optimize toEdge, IndexEdgeDeserializable.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SteamShon @em3s @daewon @elric-k