Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add configuration for build docker image in server module #1885

Merged
merged 109 commits into from
Nov 22, 2019
Merged

feature: add configuration for build docker image in server module #1885

merged 109 commits into from
Nov 22, 2019

Conversation

helloworlde
Copy link
Contributor

@helloworlde helloworlde commented Nov 10, 2019

Ⅰ. Describe what this PR did

Add configuration for build Docker image in server module.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

This PR can't add test cases in code.

Ⅳ. Describe how to verify it

  1. Add REGISTRY_USERNAME and REGISTRY_PASSWORD environment which docker account and password.
  2. Execute mvn clean package -P image and then will push latest tag image in your docker hub.

Ⅴ. Special notes for reviews

  • Need to add two environment parameter in Travis: REGISTRY_USERNAME and REGISTRY_PASSWORD
  • The namespace seata.io need to check if is belong to us, or need to change others.
  • Add one profile for docker image named image
  • There has two scene to build image:
    • Use image profile, will build and upload the latest tag image.
    • Use release profile, will build and upload the latest and ${project.version} tag images.

And there has a very important thing is that we need change path of registry.conf and file.conf, now if we want mount configuration volume to container, we need add not only registry.conf and file.conf, but also all files under resources. So move the two files to another folder maybe is a good choice

@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

Merging #1885 into develop will decrease coverage by 0.08%.
The diff coverage is 21.21%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1885      +/-   ##
=============================================
- Coverage      55.27%   55.18%   -0.09%     
- Complexity      2401     2404       +3     
=============================================
  Files            428      429       +1     
  Lines          14219    14246      +27     
  Branches        1664     1668       +4     
=============================================
+ Hits            7859     7862       +3     
- Misses          5658     5679      +21     
- Partials         702      705       +3
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/seata/common/util/StringUtils.java 26.19% <0%> (-1.31%) 16 <0> (ø)
...rc/main/java/io/seata/common/util/NumberUtils.java 0% <0%> (ø) 0 <0> (?)
...src/main/java/io/seata/server/ParameterParser.java 46.8% <30.43%> (-9.86%) 11 <6> (+3)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 64.56% <0%> (+0.78%) 25% <0%> (ø) ⬇️

@helloworlde helloworlde changed the title feature: Add configuration for build Docker image in server module. feature: Add configuration for build Docker image in server module Nov 10, 2019
@zjinlei zjinlei added this to the 1.0 milestone Nov 12, 2019
@slievrly
Copy link
Member

@helloworlde How to control the account permissions of docker.io?

@helloworlde helloworlde reopened this Nov 18, 2019
server/pom.xml Outdated Show resolved Hide resolved
@apache apache deleted a comment from helloworlde Nov 19, 2019
@slievrly
Copy link
Member

Has been discussed with @helloworlde , use profile for configuration isolation, use travis env environment variable to control account.

@slievrly slievrly changed the title feature: Add configuration for build Docker image in server module feature: add configuration for build docker image in server module Nov 19, 2019
server/pom.xml Outdated Show resolved Hide resolved
server/pom.xml Outdated Show resolved Hide resolved
server/pom.xml Outdated Show resolved Hide resolved
jsbxyyx and others added 25 commits November 20, 2019 14:52
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 53487ef into apache:develop Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet