-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add configuration for build docker image in server module #1885
Conversation
release 0.5.2
Release 0.6.1
release 0.7.1
release 0.8.0
Codecov Report
@@ Coverage Diff @@
## develop #1885 +/- ##
=============================================
- Coverage 55.27% 55.18% -0.09%
- Complexity 2401 2404 +3
=============================================
Files 428 429 +1
Lines 14219 14246 +27
Branches 1664 1668 +4
=============================================
+ Hits 7859 7862 +3
- Misses 5658 5679 +21
- Partials 702 705 +3
|
@helloworlde How to control the account permissions of docker.io? |
Has been discussed with @helloworlde , use profile for configuration isolation, use travis env environment variable to control account. |
# Conflicts: # .travis.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
Add configuration for build Docker image in server module.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
This PR can't add test cases in code.
Ⅳ. Describe how to verify it
REGISTRY_USERNAME
andREGISTRY_PASSWORD
environment which docker account and password.mvn clean package -P image
and then will pushlatest
tag image in your docker hub.Ⅴ. Special notes for reviews
REGISTRY_USERNAME
andREGISTRY_PASSWORD
seata.io
need to check if is belong to us, or need to change others.image
image
profile, will build and upload thelatest
tag image.release
profile, will build and upload thelatest
and${project.version}
tag images.And there has a very important thing is that we need change path of
registry.conf
andfile.conf
, now if we want mount configuration volume to container, we need add not onlyregistry.conf
andfile.conf
, but also all files underresources
. So move the two files to another folder maybe is a good choice