Skip to content

Conversation

@mahall
Copy link

@mahall mahall commented Jan 29, 2014

I would like to be able to log at varying levels from multilang spouts and bolts. I updated the log function in storm.py to make the call.

I propose the following change in the wiki doc https://github.com/nathanmarz/storm/wiki/Multilang-protocol as well.

{
"command": "log",
// the message to log
"msg": "hello world!",
// the level to log at (optional, defaults to info)
"level": "warn"
}

@mahall mahall closed this Mar 25, 2014
@mahall mahall deleted the 0.9.0-treasure branch March 25, 2014 23:57
@dan-blanchard
Copy link
Contributor

Was this abandoned?

@msukmanowsky
Copy link

I also opened up a pull request for this prior to the move to Apache nathanmarz/storm#626.

@revans2
Copy link
Contributor

revans2 commented Jul 17, 2014

Wow, I am sorry about not getting around to reviewing this. The code change looks good if someone wants to file a JIRA for this and update the pull request or file a new one I would be happy to give it a +1

@dan-blanchard
Copy link
Contributor

The one @msukmanowsky wrote seems a bit more efficient than this one, since it sends the logging levels as integers.

@revans2
Copy link
Contributor

revans2 commented Jul 17, 2014

That is true and it was the feedback that Nathan gave. But this version updates both the ShellSpout and the ShellBolt, and also updates the python library. It would be good to combine the two. And if someone feels like updating the ruby code that would be great too. Although the ruby library could just be done as a follow on request.

@dashengju
Copy link
Contributor

@revans2 I will file a JIRA for this and file a new pull request for this function.

@dashengju
Copy link
Contributor

I have filed a JIRA and a new PR (#196) for this proposal.

knusbaum pushed a commit to knusbaum/incubator-storm that referenced this pull request Feb 11, 2015
Added support for the build to tag the repo with the exact build number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants