This repository was archived by the owner on Jun 3, 2021. It is now read-only.
[android] Upgrade css-layout to yoga library#476
Closed
sospartan wants to merge 4 commits into
Closed
Conversation
sospartan
changed the title
WXDomObject now inherit YogaNode, which is wrapper for object in jni. minSDKVersion change to 15, the yoga library required. I’ve make a PR to yoga, and it accepted by yoga. So yoga will change minSDKVersion to 14. After that, we can change it back to 14 too. Spacing from old css-layout library will stay, because the ImmutableDomObject use it. Clean css-layout code will in another seperate commit. Some new rule: - 'Only leaf nodes with custom measure functionsshould manually mark themselves as dirty - 'Cannot add child: Nodes with measure functions cannot have children' Measure Function in Weex are modified according these rules. The ‘clone’ method from WXDomObject is deprecated. Use a ‘asResult’ to return the data object need by components.
New YogaNode use jni, in junit it's hard to mock with tiny modification. Disable temporarily, fix junit by another PR.
sospartan
force-pushed
the
android-feature-yoga
branch
from
9e38821 to
92f2cb5
Compare
|
Any progress? |
Contributor
|
weex will not use yoga,so close this pr .thanks @sospartan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue : https://issues.apache.org/jira/browse/WEEX-34
Upgrade
css-layouttoyoga.This is a huge PR, better reviewing by commits.
Notable changes:
WXDomObject now inherit YogaNode, which is wrapper for object in jni.
minSDKVersion change to 15, the yoga library required. I’ve make a PR to yoga, and it accepted by yoga. So yoga will change minSDKVersion to 14. After that, we can change it back to 14 too.
Spacing from old css-layout library will stay, because the ImmutableDomObject use it.
Clean css-layout code will in another seperate commit.
Some new rule:
Measure Function in Weex are modified according these rules.
The ‘clone’ method from WXDomObject is deprecated. Use a ‘asResult’ to return the data object need by components.