verify-action-build: support .cjs and .mjs compiled bundles#734
Merged
verify-action-build: support .cjs and .mjs compiled bundles#734
Conversation
Member
Author
|
needs #735 |
The Dockerfile that rebuilds an action's bundle and diff_js only looked for *.js. Actions bundled with esbuild or rollup often emit dist/index.cjs (when the source package declares "type": "module" and needs a CommonJS bundle for the node runner — JustinBeckwith/linkinator-action v2.4.2 is the current trigger) or dist/index.mjs. For those actions the current pipeline both skips deleting the published bundle before rebuild (so a broken build is masked by the leftover file) and reports "No compiled JavaScript found" because the comparison walks only *.js. Extend the pre-rebuild delete step and the has_output probe in build_action.Dockerfile to cover *.js, *.cjs and *.mjs, and factor the file-collection in diff_js.py into a _collect_compiled_js helper that scans all three extensions. Add unit tests covering the helper including nested output directories (e.g. dist/sub/main/index.cjs). Generated-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
potiuk
force-pushed
the
verify-action-cjs-mjs-support
branch
from
3f56836 to
66ff315
Compare
Member
Author
|
Looks good now - needs approval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivated by Dependabot PR #720 bumping
JustinBeckwith/linkinator-actionto v2.4.2. That action declaresmain: dist/index.cjsin action.yml and itsnpm run buildinvokes esbuild with--format=cjs --outfile=dist/index.cjs. Ourverify-action-buildpipeline only recognized*.js, so for any.cjs/.mjsbundle it:diff_js_files, skipping the original-vs-rebuilt comparison entirely.Changes
utils/verify_action_build/dockerfiles/build_action.Dockerfile*.js,*.cjs,*.mjs.has_output()probe that decides whether to try the next build step now recognizes all three extensions.utils/verify_action_build/diff_js.py_collect_compiled_js(base)helper scans*.js,*.cjs,*.mjs.diff_js_filesuses the helper.utils/tests/verify_action_build/test_diff_js.pydist/sub/main/index.cjs— the gradle/actions-style monorepo shape).How
dist/index.cjsis rebuiltlinkinator-action's
package.jsonhas\"type\": \"module\"and:\"build\": \"esbuild src/index.js --bundle --platform=node --format=cjs --outfile=dist/index.cjs --sourcemap\"So when the Dockerfile runs
npm run buildinside the build dir, esbuild emitsdist/index.cjs(+dist/index.cjs.map). With the oldfind ... -name '*.js'guard the rebuild step'shas_outputreturned false after esbuild succeeded, causing the Dockerfile to fall through to thenpx ncc build --source-mapfallback — which either failed or produceddist/index.js, something the action never ships. With this change the esbuild output is recognized as the final build artifact and compared directly against the committeddist/index.cjs.Test plan
uv run --with pytest pytest tests/verify_action_build— 120 passed (includes 3 new)verify-action-buildend-to-end againstJustinBeckwith/linkinator-action@7b6b0bc(PR action-allowlist-review: bump JustinBeckwith/linkinator-action from 2.4.1 to 2.4.2 in /.github/actions/for-dependabot-triggered-reviews #720 target) once CI has access to Docker, and confirm the pre-rebuild delete log listsdist/index.cjsand the diff step reports the rebuild matches.🤖 Generated with Claude Code