verify-action-build: keep non-minified JS, diff vs approved version#777
Merged
verify-action-build: keep non-minified JS, diff vs approved version#777
Conversation
A clean rebuild of non-minified bundles (Deno's `deno task bundle`, Dart's `dart compile js`, esbuild non-minified output) tends to differ from the committed `dist/` only in toolchain-version noise — esbuild, ncc and webpack boilerplate evolve between versions and the diff isn't actionable for review. Until now those files showed up as "non-minified — rebuild differs" warnings that reviewers couldn't act on; surfaced again on PR #736 against `Kesin11/actions-timeline`. Treat them differently: in the pre-rebuild deletion step the Dockerfile now skips files that look non-minified (<10 lines, or average line length >500 chars — same heuristic as `is_minified()` in `diff_js.py`) and records each kept path in `/kept-js.log`. The rebuild comparison short-circuits these files with a yellow note pointing at the approved-vs-new diff, and `diff_approved_vs_new()` now diffs them against the previously-approved version (overriding its `dist/` exclusion) with `beautify_js()` applied so huge bundles render readably. Reviewers see real source changes between versions instead of toolchain artifacts. Minified bundles still take the full delete-and-rebuild path, so hand-written or unbuilt JS in `dist/` is still caught. Tests: `test_keeps_non_minified_compiled_js` guards the Dockerfile heuristic; `TestDiffJsKeptFiles` covers the `kept_files` short-circuit in `diff_js`. README updated to describe the behaviour. Generated-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dart compile js, esbuild readable output) the rebuild produces toolchain-version noise rather than actionable diffs — surfaced as "non-minified — rebuild differs" warnings on PRs like action-allowlist-review: bump Kesin11/actions-timeline from 3.0.0 to 3.1.0 in /.github/actions/for-dependabot-triggered-reviews #736./kept-js.log) and diff them against the previously-approved version instead, withbeautify_js()applied so the diff renders readably.dist/is still caught.Test plan
uv run pytest— 199 tests pass locally; newtest_keeps_non_minified_compiled_jsandTestDiffJsKeptFilescover the Dockerfile heuristic and the diff_js short-circuitverifyworkflow on PR action-allowlist-review: bump Kesin11/actions-timeline from 3.0.0 to 3.1.0 in /.github/actions/for-dependabot-triggered-reviews #736 and confirmpost.jsis reported as kept (yellow~, "diffed against previously-approved version below") rather than "rebuild differs"dist/post.jsappears in the approved-vs-new diff section, beautified🤖 Generated with Claude Code