Skip to content

hotfix: unblock CI (license headers + pyyaml dep)#882

Merged
potiuk merged 1 commit into
mainfrom
fix-pytest-rat-precommit-on-main
May 22, 2026
Merged

hotfix: unblock CI (license headers + pyyaml dep)#882
potiuk merged 1 commit into
mainfrom
fix-pytest-rat-precommit-on-main

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented May 22, 2026

Summary

Three required checks (pre-commit, pytest, rat) fail on every open
PR because utils/check_cache_settings/ was merged with two missing
pieces:

  • audit-actions-cache.py + test_audit_actions_cache.py are missing
    Apache license headers — pre-commit's insert-license hook auto-adds
    them and exits 1, and rat counts 1 unapproved file.
  • test_audit_actions_cache.py does import yaml but no PyYAML is in
    any dep set, so uv run pytest can't collect the test module:
    ModuleNotFoundError: No module named 'yaml'.

Changes:

  • Apache license header on both files (prek auto-insertion).
  • pyyaml>=6.0 added to root pyproject.toml [dependency-groups].dev;
    uv.lock updated.

After this lands, the affected dependabot PRs can be unstuck with
@dependabot rebase and #876 with a plain rebase.

Test plan

  • prek run --all-files — clean
  • uv run pytest — 469 passed (previously failed collection)
  • Confirm CI goes green on pre-commit, pytest, rat

Three required checks (pre-commit, pytest, rat) currently fail on every
open PR because utils/check_cache_settings/ landed on main with two
missing pieces:

- audit-actions-cache.py + test_audit_actions_cache.py have no Apache
  license header — pre-commit auto-inserts and exits 1, rat counts 1
  unapproved file.
- test_audit_actions_cache.py does `import yaml` but no PyYAML is
  declared anywhere, so `uv run pytest` can't collect the test module
  (ModuleNotFoundError).

Adds the headers and pyyaml>=6.0 to the root dev-dependency group; the
affected open PRs can then be unstuck with `@dependabot rebase`
(dependabot bumps) or a plain rebase.

Generated-by: Claude Opus 4.7 (1M context)
@potiuk potiuk requested review from dfoulks1 and ppkarwasz as code owners May 22, 2026 13:52
@potiuk potiuk merged commit 6bc275a into main May 22, 2026
8 checks passed
@potiuk potiuk deleted the fix-pytest-rat-precommit-on-main branch May 22, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants