[INLONG-576] Optimize document style layout#577
Closed
bluewang wants to merge 3 commits intoapache:masterfrom
Closed
[INLONG-576] Optimize document style layout#577bluewang wants to merge 3 commits intoapache:masterfrom
bluewang wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
what is the effect of this PR change? |
Contributor
Author
It looks better than before |
dockerzhang
approved these changes
Oct 26, 2022
healchow
approved these changes
Oct 26, 2022
leezng
reviewed
Oct 26, 2022
Member
leezng
left a comment
leezng
left a comment
There was a problem hiding this comment.
It doesn't seem to fit well on a small screen.
Contributor
@bluewang PTAL, thanks. |
Member
|
After discussion, we do not recommend changing the underlying design of the framework, which is more customized, and it may be troublesome for us to upgrade its framework version in the future. So, close the PR first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)