Skip to content

[INLONG-10094][agent] Fix the bug: the task record for data supplementation has not expired#10095

Merged
justinwwhuang merged 2 commits intoapache:masterfrom
justinwwhuang:b10094
Apr 29, 2024
Merged

[INLONG-10094][agent] Fix the bug: the task record for data supplementation has not expired#10095
justinwwhuang merged 2 commits intoapache:masterfrom
justinwwhuang:b10094

Conversation

@justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Apr 28, 2024

Fixes #10094

Motivation

Fix the bug: the task record for data supplementation has not expired

Modifications

Put the logic of deleting expired records into OffsetManager for unified management

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@justinwwhuang justinwwhuang added this to the 1.13.0 milestone Apr 28, 2024
@justinwwhuang justinwwhuang self-assigned this Apr 28, 2024
Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinwwhuang justinwwhuang requested a review from doleyzi April 29, 2024 01:45
@justinwwhuang justinwwhuang merged commit fabb0c4 into apache:master Apr 29, 2024
@justinwwhuang justinwwhuang deleted the b10094 branch April 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improve][Agent] The task record for data supplementation has not expired

3 participants