Skip to content

Comments

[INLONG-10942][SDK] Add official function names for all Transform functions#10943

Merged
aloyszhang merged 1 commit intoapache:masterfrom
Zkplo:INLONG-10942
Sep 2, 2024
Merged

[INLONG-10942][SDK] Add official function names for all Transform functions#10943
aloyszhang merged 1 commit intoapache:masterfrom
Zkplo:INLONG-10942

Conversation

@Zkplo
Copy link
Contributor

@Zkplo Zkplo commented Aug 29, 2024

Fixes #10942

Motivation

Added official SQL functions for DateExtractFunction, FromUnixTimeFunction, SubstringFunction, and TimestampAdFunction classes

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

@aloyszhang
Copy link
Contributor

aloyszhang commented Aug 29, 2024

Is there any specifications for "official function names"?

@Zkplo
Copy link
Contributor Author

Zkplo commented Aug 30, 2024

Is there any specifications for "official function names"?“官方函数名称”有什么规范吗?

The official function name refers to the built-in function name defined in SQL, such as the dayofmont() function. When writing the function of inlong transform, due to readability, the function name may be defined as day_of_month. However, because it is inconsistent with the dayofmonth function name, it may cause difficulties for the caller to use it. Therefore, it is necessary to add an alias that is consistent with dayofmonth, so that the caller can call the function using both day_of_month and dayofmonth.

@aloyszhang aloyszhang merged commit 4de972e into apache:master Sep 2, 2024
@Zkplo Zkplo deleted the INLONG-10942 branch September 2, 2024 10:18
MOONSakura0614 pushed a commit to MOONSakura0614/inlong that referenced this pull request Sep 3, 2024
wohainilaodou pushed a commit to wohainilaodou/inlong that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][SDK] Add official function names for all Transform functions

3 participants