[INLONG-10942][SDK] Add official function names for all Transform functions#10943
Merged
aloyszhang merged 1 commit intoapache:masterfrom Sep 2, 2024
Merged
[INLONG-10942][SDK] Add official function names for all Transform functions#10943aloyszhang merged 1 commit intoapache:masterfrom
aloyszhang merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Is there any specifications for "official function names"? |
Contributor
Author
The official function name refers to the built-in function name defined in SQL, such as the dayofmont() function. When writing the function of inlong transform, due to readability, the function name may be defined as day_of_month. However, because it is inconsistent with the dayofmonth function name, it may cause difficulties for the caller to use it. Therefore, it is necessary to add an alias that is consistent with dayofmonth, so that the caller can call the function using both day_of_month and dayofmonth. |
luchunliang
approved these changes
Aug 31, 2024
aloyszhang
approved these changes
Sep 2, 2024
MOONSakura0614
pushed a commit
to MOONSakura0614/inlong
that referenced
this pull request
Sep 3, 2024
wohainilaodou
pushed a commit
to wohainilaodou/inlong
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10942
Motivation
Added official SQL functions for DateExtractFunction, FromUnixTimeFunction, SubstringFunction, and TimestampAdFunction classes
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)