Skip to content

[INLONG-12133][Manager] Fix the security vulnerability in /api/cluster/testConnection #12134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fuweng11 wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −0
Open

[INLONG-12133][Manager] Fix the security vulnerability in /api/cluster/testConnection #12134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ...ice/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import org.apache.inlong.manager.common.exceptions.BusinessException;
import org.apache.inlong.manager.common.util.CommonBeanUtils;
import org.apache.inlong.manager.common.util.Preconditions;
import org.apache.inlong.manager.common.util.UrlVerificationUtils;
import org.apache.inlong.manager.dao.entity.InlongClusterEntity;
import org.apache.inlong.manager.dao.entity.InlongClusterNodeEntity;
import org.apache.inlong.manager.dao.entity.InlongClusterTagEntity;
Expand Down Expand Up @@ -940,6 +941,17 @@ public String getManagerSSHPublicKey() {

@Override
public Boolean testSSHConnection(ClusterNodeRequest request) {
// Validate IP to prevent SSRF attacks
String ip = request.getIp();
if (StringUtils.isNotBlank(ip)) {
try {
UrlVerificationUtils.validateHostNotInternal(ip);
} catch (Exception e) {
throw new BusinessException(ErrorCodeEnum.INVALID_PARAMETER,
"SSRF protection: " + e.getMessage());
}
}

AgentClusterNodeRequest nodeRequest = (AgentClusterNodeRequest) request;
try {
CommandResult commandResult = commandExecutor.execRemote(nodeRequest, "ls");
Expand Down Expand Up @@ -1271,6 +1283,17 @@ public AuditConfig getAuditConfig(String clusterTag) {
public Boolean testConnection(ClusterRequest request) {
LOGGER.info("begin test connection for: {}", request);

// Validate URL to prevent SSRF attacks
String url = request.getUrl();
if (StringUtils.isNotBlank(url)) {
try {
UrlVerificationUtils.validateUrlNotInternal(url);
} catch (Exception e) {
throw new BusinessException(ErrorCodeEnum.INVALID_PARAMETER,
"SSRF protection: " + e.getMessage());
}
}

// according to the data node type, test connection
InlongClusterOperator clusterOperator = clusterOperatorFactory.getInstance(request.getType());
Boolean result = clusterOperator.testConnection(request);
Expand Down
2 changes: 2 additions & 0 deletions ...r-web/src/main/java/org/apache/inlong/manager/web/controller/InlongClusterController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,12 +305,14 @@ public Response<String> getManagerSSHPublicKey() {

@PostMapping("/cluster/node/testSSHConnection")
@ApiOperation(value = "Test SSH connection for inlong cluster node")
@RequiresRoles(logical = Logical.OR, value = {UserRoleCode.INLONG_ADMIN, UserRoleCode.TENANT_ADMIN})
public Response<Boolean> testSSHConnection(@RequestBody ClusterNodeRequest request) {
return Response.success(clusterService.testSSHConnection(request));
}

@PostMapping("/cluster/testConnection")
@ApiOperation(value = "Test connection for inlong cluster")
@RequiresRoles(logical = Logical.OR, value = {UserRoleCode.INLONG_ADMIN, UserRoleCode.TENANT_ADMIN})
public Response<Boolean> testConnection(@Validated @RequestBody ClusterRequest request) {
return Response.success(clusterService.testConnection(request));
}
Expand Down
Loading