[INLONG-4866][Manager] Support batch task for Inlong group#4868
Closed
kipshi wants to merge 2 commits intoapache:masterfrom
Closed
[INLONG-4866][Manager] Support batch task for Inlong group#4868kipshi wants to merge 2 commits intoapache:masterfrom
kipshi wants to merge 2 commits intoapache:masterfrom
Conversation
healchow
reviewed
Jul 4, 2022
...ger-service/src/main/java/org/apache/inlong/manager/service/sort/PushSortConfigListener.java
Outdated
Show resolved
Hide resolved
leosanqing
approved these changes
Jul 5, 2022
healchow
requested changes
Jul 5, 2022
|
|
||
| public static final Integer UN_SYNC_SEND = 0; | ||
|
|
||
| public static final String BATCH_TASK = "batch.task"; |
Member
There was a problem hiding this comment.
Do we need to save this param into inlong_group table?
thesumery
reviewed
Jul 6, 2022
Contributor
thesumery
left a comment
thesumery
left a comment
There was a problem hiding this comment.
please add more description for motivation
haibo-duan
reviewed
Jul 31, 2022
| return new GroupInfo(groupId, streamInfos); | ||
| } | ||
|
|
||
| private Map<String, List<StreamSource>> createPulsarSources( |
| return ListenerResult.success(); | ||
| } | ||
|
|
||
| private void upsertDataFlow(InlongGroupInfo groupInfo, InlongGroupExtInfo extInfo) { |
Contributor
|
Duplicated with #5399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
(Change the title refer to the following example)
(The following XYZ should be replaced by the actual GitHub Issue number)
Motivation
Modifications
1 add batch.task flag for inlong group.
2 remove unused classes.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation