[INLONG-4915][Manager] Add Pulsar source type and improve connector jar discovery mechanism#4918
Merged
healchow merged 1 commit intoapache:masterfrom Jul 8, 2022
Merged
Conversation
… dependent connector jars
healchow
changed the title
LvJiancheng
approved these changes
Jul 7, 2022
2 tasks
healchow
approved these changes
Jul 8, 2022
gosonzhang
approved these changes
Jul 8, 2022
bruceneenhl
pushed a commit
to bruceneenhl/inlong
that referenced
this pull request
Aug 12, 2022
…ar discovery mechanism (apache#4918)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The pulsar source jar selector enum is missing. Add it so the jars are correctly selected when the Pulsar is used as the source node.
The current job submits implementation requires the dependent jars to be all present on the Flink node. This is not convenient when the Flink nodes are different from the manager nodes:
Modifications
Rather than placing jars before the job submits, it's more flexible and straightforward to just upload the dependent connectors with the job jar:
Pros: Easy to use. Less concern about jar management. New connectors are supported anytime.
Cons: Need to upload more files thus extra network overhead.