Skip to content

[INLONG-4806][Sort] Sort support InlongMsg pb format#5061

Merged
EMsnap merged 4 commits intoapache:masterfrom
vernedeng:INLONG-4806
Jul 19, 2022
Merged

[INLONG-4806][Sort] Sort support InlongMsg pb format#5061
EMsnap merged 4 commits intoapache:masterfrom
vernedeng:INLONG-4806

Conversation

@vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Jul 15, 2022

[INLONG-4806][Sort] Sort support consume pb message

Motivation

Sort do not support deserialize inlong pb msg format
The inner csv format will thow exception when the real field size exceeds the excepted one.

Modifications

Sort support InlongMsg pb format.
Support Csv inner format ignore tailing unmappable.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang requested a review from EMsnap July 18, 2022 02:28
@dockerzhang
Copy link
Contributor

@EMsnap @gong @thexiay PTAL, thanks.

Copy link
Contributor

@baomingyu baomingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EMsnap EMsnap merged commit 173b966 into apache:master Jul 19, 2022
bruceneenhl pushed a commit to bruceneenhl/inlong that referenced this pull request Aug 12, 2022
@vernedeng vernedeng deleted the INLONG-4806 branch May 26, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

6 participants