[INLONG-4806][Sort] Sort support InlongMsg pb format#5061
Merged
EMsnap merged 4 commits intoapache:masterfrom Jul 19, 2022
Merged
[INLONG-4806][Sort] Sort support InlongMsg pb format#5061EMsnap merged 4 commits intoapache:masterfrom
EMsnap merged 4 commits intoapache:masterfrom
Conversation
Contributor
EMsnap
reviewed
Jul 18, 2022
...c/main/java/org/apache/inlong/sort/formats/inlongmsgpb/InLongMsgPbDeserializationSchema.java
Show resolved
Hide resolved
...g-pb/src/main/java/org/apache/inlong/sort/formats/inlongmsgpb/InLongMsgPbDecodingFormat.java
Show resolved
Hide resolved
...g-pb/src/main/java/org/apache/inlong/sort/formats/inlongmsgpb/InLongMsgPbDecodingFormat.java
Outdated
Show resolved
Hide resolved
thesumery
reviewed
Jul 18, 2022
...g-pb/src/main/java/org/apache/inlong/sort/formats/inlongmsgpb/InLongMsgPbDecodingFormat.java
Outdated
Show resolved
Hide resolved
thesumery
approved these changes
Jul 19, 2022
EMsnap
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[INLONG-4806][Sort] Sort support consume pb message
Motivation
Sort do not support deserialize inlong pb msg format
The inner csv format will thow exception when the real field size exceeds the excepted one.
Modifications
Sort support InlongMsg pb format.
Support Csv inner format ignore tailing unmappable.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation