Skip to content

[INLONG-5302][Manager] Supports the extension of data consumption for different MQs#5542

Merged
dockerzhang merged 6 commits intoapache:masterfrom
ciscozhou:master
Sep 3, 2022
Merged

[INLONG-5302][Manager] Supports the extension of data consumption for different MQs#5542
dockerzhang merged 6 commits intoapache:masterfrom
ciscozhou:master

Conversation

@ciscozhou
Copy link
Contributor

@ciscozhou ciscozhou commented Aug 14, 2022 •
edited
Loading

Prepare a Pull Request

Motivation

Supports the extension of data consumption for different MQs

Modifications

  1. Merge table consumption and consumption_pulsar into table inlong_consume.
  2. Build the code of inlong_consume according to the consumption.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.
  • This change is already covered by existing tests, such as:
    (please describe tests)
  • This change added tests and can be verified as follows:

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@healchow
Copy link
Member

healchow commented Aug 14, 2022

Thanks for your contribution🎉

Please add more info for the PR.

leosanqing
leosanqing reviewed Aug 18, 2022
View reviewed changes
@ciscozhou ciscozhou force-pushed the master branch 2 times, most recently from 32d9959 to 592d5cb Compare September 1, 2022 00:58
@ciscozhou ciscozhou force-pushed the master branch 2 times, most recently from f433ec7 to c042853 Compare September 1, 2022 17:36
healchow
healchow approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@healchow healchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit 473f67b into apache:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woofyzhao woofyzhao woofyzhao approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@healchow healchow healchow approved these changes

+1 more reviewer

@leosanqing leosanqing leosanqing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Supports the extension of data consumption for different MQs

5 participants

@ciscozhou @healchow @woofyzhao @dockerzhang @leosanqing