Skip to content

Comments

[INLONG-6056][Manager] Add lookup join support for Join node#6057

Closed
JJiacheng wants to merge 1 commit intoapache:masterfrom
JJiacheng:INLONG-6056
Closed

[INLONG-6056][Manager] Add lookup join support for Join node#6057
JJiacheng wants to merge 1 commit intoapache:masterfrom
JJiacheng:INLONG-6056

Conversation

@JJiacheng
Copy link
Contributor

@JJiacheng JJiacheng commented Sep 28, 2022

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! 💖 This seems to be your first PR! 🌠 Please be sure to follow our contribution guidelines! 🎁

@JJiacheng JJiacheng reopened this Sep 28, 2022
@JJiacheng JJiacheng changed the title [INLONG-6065] Add lookup join support for Join node [INLONG-6065][Manager] Add lookup join support for Join node Sep 28, 2022
@JJiacheng JJiacheng changed the title [INLONG-6065][Manager] Add lookup join support for Join node [INLONG-6056][Manager] Add lookup join support for Join node Sep 29, 2022
@JJiacheng JJiacheng closed this Sep 29, 2022
@JJiacheng JJiacheng deleted the INLONG-6056 branch September 29, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Manager] Add lookup join support for Join node

1 participant